100 PaperCuts - Sprint 2

[James Falkner, modificado 13 Anos atrás.]

Sprint 2 Details

Welcome to our 3 new members Hitesh, Jelmer, and Jaromir! You can see all team members on the landing page.

This post is in a new Forum category for 100 PaperCuts. Please click "subscribe" on the category page so that you receive emails for the 100 PaperCuts discussions. From now on we'll use this forum for all discussions regarding 100 PaperCuts.

Sprint 2 is beginning today. As we learned in the last sprint, it will work better if you can choose which papercut you wish to work on. We've identified several candidate bugs for you to choose from, but you can also find any on your own (especially if they are bugs you wish to be fixed for your own reasons).

The bugs that we've identified as potential papercuts can be seen using this JIRA filter. Please check out this list, and if there is an issue you wish to work on, please post up on the forum thread for Sprint 2, AND add the following comment to the bug: "This issue is currently being addressed in Sprint X of the 100 PaperCuts program. Please see http://liferay.com/community/100-papercuts". (replace "X" with the sprint #). I will be editing the Sprint Wiki Page to identify who is working on what.

If there is a bug that you believe is a papercut, and want to add it to the list of potential bugs (but not necessarily one that you personally want to work on), please add the following comment:

"This issue is a backlog candidate for the 100 PaperCuts program. Please consider participating! See http://liferay.com/community/100-papercuts"

This will cause it to show up on the above JIRA filter for potential backlog bugs. Again, you are free to choose any open bug that's not currently being worked on by someone else. You can tell a bug is being worked on if it has a "Fixed In" assignment of "Sprint -- XX/XX" (such as "Sprint -- 02/11") or is in some state other than "Open" (such as "In Progress" or "In Review").

When you have identified which bug you wish to work on for Sprint 2, please post up on this thread to let everyone know, and I'll add it to the wiki. If you don't pick one by Friday you may be auto-assigned one Good hunting!

[Jaromir Hamala, modificado 13 Anos atrás.]

Hello guys,
thank you for allowing me to participate. I'd like to look at "LPS-10263 - Remove the mandatory URL from announcements entries". It seems to be easy enough to start with, yet according to discussion in forum it's quite annoying.

[James Falkner, modificado 13 Anos atrás.]

Jaromir Hamala:

Hello guys,
thank you for allowing me to participate. I'd like to look at "LPS-10263 - Remove the mandatory URL from announcements entries". It seems to be easy enough to start with, yet according to discussion in forum it's quite annoying.

Wow, great choice. It's yours!

[Jaromir Hamala, modificado 13 Anos atrás.]

Hello,
I just started to analyze my issue(LPS-10263) and found out that it has been already resolved in trunk. I'm sorry for not checking this before :-(

[James Falkner, modificado 13 Anos atrás.]

Jaromir Hamala:

Hello,
I just started to analyze my issue(LPS-10263) and found out that it has been already resolved in trunk. I'm sorry for not checking this before :-(

That's cool. We'll just move onto another for the next sprint (beginning next Wednesday). In the meantime, take a look at the candidate bugs or choose your own for the next sprint.

[Deb Troxel, modificado 13 Anos atrás.]

I'll take a shot at http://issues.liferay.com/browse/LPS-11854
"Web Form Portlet Configuration -- Changing type field does not appear to work at all in IE8."

[jelmer kuperus, modificado 13 Anos atrás.]

LPS-12918 has my name on it

[James Falkner, modificado 13 Anos atrás.]

jelmer kuperus:

LPS-12918 has my name on it

Deb, Jelmer: Done!

[Tomas Polesovsky, modificado 13 Anos atrás.]

Hi James and all,

I'll take this one for the 2nd sprint: LPS-11479

-- tom

[jelmer kuperus, modificado 13 Anos atrás.]

Hey Tomas, to be honest I am not sure that LPS-11479 is something that should be addressed as a papercut. Remember that the aim of the project is to identify and fix high-visibility, easy to correct bugs in Liferay Portal

I don't think this qualifies as a high-visibility bug, it's more of a lacking feature, and one that is easy to work around too

You can add a getProducto method to FormatoImpl like this

public class FormatoImpl {
   public Producto getProducto() {
       if (idProducto == 0) {
          return null;
       }
       return ProductoLocalServiceUtil.getProducto(idProducto);
   }
}

regenerate the service and you are done. It isn't particularly pretty but it seems to be how it is done in the core of Liferay


And unless you plan to implement this feature as servicebuilder generating the type of method that i just mentioned. This "bug" won't be easy to solve either.

[Tomas Polesovsky, modificado 13 Anos atrás.]

Hi Jelmer,

thanks for feedback and specially for the better solution. Yes I planned it as ServiceBuilder patch.

I do think it's high-visible (http://issues.liferay.com/secure/IssueNavigator.jspa?reset=true&pid=10952&sorter/field=votes&sorter/order=DESC) and that's why I want to fix it.

Can I invite you to comment on LPS-11479 - how to fix it (because I'm not sure this thread is the right thread for this). Your workaround is great and maybe it is sufficient just as comment (so everyone can happily apply it) - that could be the final solution - I just want to help people not to generate more code On the other hand it can be worth to change ServiceBuilder to generate it OOTB? I really don't know and I don't want to decide it by myself, I think the community (the voters) could tell?

What do you think?

-- tom

[jelmer kuperus, modificado 13 Anos atrás.]

Actually I think this is a design decision and as such should be made by the core Liferay engineers.

[Juan Gonzalez P, modificado 13 Anos atrás.]

I'll take this one if nobody cares :

http://issues.liferay.com/browse/LPS-7503 --> Give alternatives to <object>

[Baptiste Grenier, modificado 13 Anos atrás.]

Hello,
I can try to fix the http://issues.liferay.com/browse/LPS-13210 issue.
Cheers,
Baptiste

[Tomas Polesovsky, modificado 13 Anos atrás.]

Hello James,

please could you help me decide what to do with LPS-11479? Jelmer's workaround is good so should I abandon this ticket and pick another one or do you think to create patch could be helpful?

Thank you.

-- tom

[Juan Fernández, modificado 13 Anos atrás.]

Go, Liferay Heroes, go!!!

[Tomas Polesovsky, modificado 13 Anos atrás.]

After short discussion with James on IRC I'll abandon LPS-11479.

For Spring 2 I'm choosing LPS-14071.

[jelmer kuperus, modificado 13 Anos atrás.]

Isn't that one already being adressed?

it says

Fix Version/s:
--Sprint - SP, 6.1.X

[Tomas Polesovsky, modificado 13 Anos atrás.]

Jelmer, you are right

Guys, I'm sorry, I've had too much work and in the rest of my free time I'm very tired. I see that I'm not able even to choose the right ticket, thus please don't count on me for this sprint. Thanks Jelmer for your patience.

See you next sprint.

-- tom

[Corné Aussems, modificado 13 Anos atrás.]

Sorry lads i have to forfait,

I have to prepare for and visit my new Indian colleagues and can't find any sparetime.

Keep up the good work, i'll be back hopefully

[James Falkner, modificado 13 Anos atrás.]

Corné Aussems:

Sorry lads i have to forfait,

I have to prepare for and visit my new Indian colleagues and can't find any sparetime.

Keep up the good work, i'll be back hopefully

Ok, we're 1 week in, with 3 of the 8 papercuts fixed, 5 to go! Nice work so far! Let me know if you don't think you'll be able to fix your papercut by next Wednesday. We can redirect it to someone else!

[Juan Gonzalez P, modificado 13 Anos atrás.]

Hi James,

I guess my issue:

http://issues.liferay.com/browse/LPS-7503

is resolved too.

Could you give me another issue so I can solve it by next 2 days?

Thanks!

[Baptiste Grenier, modificado 13 Anos atrás.]

Issue http://issues.liferay.com/browse/LPS-14905 is now closed...

Regards,
Baptiste

PS: For next sprint, will it be possible for me to work on this one: http://issues.liferay.com/browse/LPS-15491

[James Falkner, modificado 13 Anos atrás.]

Baptiste Grenier:

Issue http://issues.liferay.com/browse/LPS-14905 is now closed...

Regards,
Baptiste

PS: For next sprint, will it be possible for me to work on this one: http://issues.liferay.com/browse/LPS-15491

Normally we'd pick bugs, not improvements, however this one sounds particularly nice, I hate having to manually link things, so yeah, you should work on that one for the next sprint!

[James Falkner, modificado 13 Anos atrás.]

Juan Gonzalez P:

Hi James,

I guess my issue:

http://issues.liferay.com/browse/LPS-7503

is resolved too.

Could you give me another issue so I can solve it by next 2 days?

Thanks!

Juan,

Sent a msg to Julio asking to comment on this. In the meantime, could you take a look at http://issues.liferay.com/browse/LPS-8968 ? I ran into this as well, and it should be an easy fix.

[Boubker TAGNAOUTI, modificado 13 Anos atrás.]

Hi James,

It seems that older versions of tickets (aka LEP) does not allow "Contributed Solution" status.

I updated this ticket with a partial patch (the problem seems to be bigger than i expected) http://issues.liferay.com/browse/LEP-6973

I have noted other bugs related to export permissions with ALGORITHM_1_4.
I'm going to create tickets for this.

[jelmer kuperus, modificado 13 Anos atrás.]

Hey Boubker, I think you have code reformatting enabled in your ide. This leads to a large number of unrelated changes in your patch. Obscuring what you actually changed

[James Falkner, modificado 13 Anos atrás.]

jelmer kuperus:

Hey Boubker, I think you have code reformatting enabled in your ide. This leads to a large number of unrelated changes in your patch. Obscuring what you actually changed

Yeah, please make sure to only include the diffs for the actual bugfix. We have an automated code reformatter (code named Brian Chan ) who reformats a bunch of things for you

[Boubker TAGNAOUTI, modificado 13 Anos atrás.]

Thank Jelmer for the info, i'm going to commit another patch later today.
I used the computer of a team member that has enabled this option on his ide ;-)

Yeah, please make sure to only include the diffs for the actual bugfix. We have an automated code reformatter (code named Brian Chan ) who reformats a bunch of things for you

Who doesn't know the automated code reformatter for this project ;-)

[Boubker TAGNAOUTI, modificado 13 Anos atrás.]

Hey James,

Is there any way to change the status of this ticket LEP-6973?

[James Falkner, modificado 13 Anos atrás.]

Boubker TAGNAOUTI:

Hey James,

Is there any way to change the status of this ticket LEP-6973?

Yeah.. for bugs that we fix where the original submitter no longer responds, we will transfer the bug ownership to me and I'll test and accept the fix. So stay tuned.

[Boubker TAGNAOUTI, modificado 13 Anos atrás.]

Cool

[James Falkner, modificado 13 Anos atrás.]

We wrapped up Sprint 2 - out of the 8 bugs identified, we fixed 5 of them. 3 of them turned out to not be papercuts, involving a much more detailed fix than was initially thought.

Tomas, Juan, and Baptiste, if you guys want to continue working on your sprint 2 bugs in sprint 3, let me know. But I suggest we move on to bigger and better things

I added LPS-15491 as a potential papercut. It looks easy and would be a real nice usability improvement. Any takers for sprint 3?

I updated the wiki page with the results from Sprint 2.

For Sprint 3, I'd really like to get back to 10 bugs to work on. So please pick your bugs for sprint 3. As a reminder, to choose a bug, check out the candidates list, or choose your own. Here's a handy filter showing those bugs marked for the community AND for liferay staff, but only those which have not been chosen for a particular liferay engineering sprint. Lots of potential bugs there.

[Tomas Polesovsky, modificado 13 Anos atrás.]

James, I don't want to continue on Sprint 2 tickets - they both seem that are not the right Papercut issues.

I can take LPS-15491 if noone other would be interested, anyway I choose one from the Candidate bugs. Thank you for that filter, it's much easier now to choose

-- tom

[Juan Gonzalez P, modificado 13 Anos atrás.]

Hi James,

Sorry I couldn't get my issue fixed. It requires more work to it.

I'll search another candidate and let you know.

Thanks

[Baptiste Grenier, modificado 13 Anos atrás.]

James Falkner:

We wrapped up Sprint 2 - out of the 8 bugs identified, we fixed 5 of them. 3 of them turned out to not be papercuts, involving a much more detailed fix than was initially thought.

Tomas, Juan, and Baptiste, if you guys want to continue working on your sprint 2 bugs in sprint 3, let me know. But I suggest we move on to bigger and better things

Hi James,
According to the previous discussions in this thread: http://www.liferay.com/community/forums/-/message_boards/message/7644098#_19_message_7671668, Eduardo will handle the LPS-13210 issue.
So I choose to work on this one : http://issues.liferay.com/browse/LPS-14905 which after some tests by me and Sophia Zhang appears to be resolved and is now in Fixed state.
So even if I did not provide any line of code, for me the Sprint 2 seems over/complete, no?

For sprint 3 I would be very happy to implement the feature that I did propose: http://issues.liferay.com/browse/LPS-15491

Cheers,
Baptiste

[James Falkner, modificado 13 Anos atrás.]

Ok Baptiste - I updated the wiki page and assigned you LPS-15491 for sprint 3 - sorry Tomas, but Baptiste actually found this one and wanted to work on it Can you choose another?

[Baptiste Grenier, modificado 13 Anos atrás.]

James Falkner:

Ok Baptiste - I updated the wiki page and assigned you LPS-15491 for sprint 3 - sorry Tomas, but Baptiste actually found this one and wanted to work on it Can you choose another?

Sorry Tomas, I didn't read carefully enough the thead so I did not see that you proposed to work on this feature...

[Tomas Polesovsky, modificado 13 Anos atrás.]

Baptiste,

no problem - go ahead It's not the last bug on the planet we should fight for

It was just my backup ticket ;)

-- tom

[Juan Gonzalez P, modificado 13 Anos atrás.]

Hi James

Can I try to solve this issue?:

http://issues.liferay.com/browse/LPS-15494

[James Falkner, modificado 13 Anos atrás.]

Juan Gonzalez P:

Hi James

Can I try to solve this issue?:

http://issues.liferay.com/browse/LPS-15494

All yours! This is for sprint 3 which begins on Wednesday (though you can start today of course!).

[Rafał Piotrowski, modificado 13 Anos atrás.]

Hi,

In sprint 3 I would like to do this one:
http://issues.liferay.com/browse/LPS-15791

[James Falkner, modificado 13 Anos atrás.]

Rafał Piotrowski:

Hi,

In sprint 3 I would like to do this one:
http://issues.liferay.com/browse/LPS-15791

Great! I've added it to the wiki.

[Szymon Gołębiewski, modificado 13 Anos atrás.]

James,

There is somekind of problem with that wiki page (creole error) :|

[James Falkner, modificado 13 Anos atrás.]

Szymon Gołębiewski:

James,

There is some kind of problem with that wiki page (creole error) :|

This just started happening a month or so ago, I have seen it multiple times. I have a feeling we upgraded to use JSPWiki's built-in Creole filter (as opposed to an older open source standalone Creole filter that is no longer being maintained). I've asked the web guys @ Liferay about it, no response yet.

The odd part is that if I simply click "Edit", make no changes, and re-save, it starts working again. And in a couple of cases, all I had to do was click "Edit" then "Cancel". Very odd. Definitely a bug in there somewhere. I'll try again to engage the web guys and see if we can figure it out.

I've re-saved the wiki page and it seems to be working now.

[Szymon Gołębiewski, modificado 13 Anos atrás.]

Maybe it is a candidate for "100 Paper Cuts" made by Liferay staff ;)

[jelmer kuperus, modificado 13 Anos atrás.]

Log an issue with reproduction steps and i'll pick it up

talk about scratching your own itch

[James Falkner, modificado 13 Anos atrás.]

jelmer kuperus:

Log an issue with reproduction steps and i'll pick it up

talk about scratching your own itch

Definitely.. my guess is that as part of LPS-13422 we updated to use JSPWiki, and then that found its way to the version of Liferay used for liferay.com. I'll see if it's reproducible in 6.0.6 using this other filter. I bet it will be. I'll file a separate bug and assign Jelmer to it if so :-)

[James Falkner, modificado 13 Anos atrás.]

James Falkner:

jelmer kuperus:

Log an issue with reproduction steps and i'll pick it up

talk about scratching your own itch

Definitely.. my guess is that as part of LPS-13422 we updated to use JSPWiki, and then that found its way to the version of Liferay used for liferay.com. I'll see if it's reproducible in 6.0.6 using this other filter. I bet it will be. I'll file a separate bug and assign Jelmer to it if so :-)

I haven't been able to reproduce it yet - however I have been able to reproduce a big time performance issue - I took the source wiki markup from the 100PC page, cut and pasted it twice into a new wiki page (on my test machine running trunk + the upgraded JSPWiki), and it took almost 10 minutes to render, spinning tightly in a loop within JSPWiki's creole filter. I'll do some more digging and file a bug by end of day and you can pick up where I left off!

[jelmer kuperus, modificado 13 Anos atrás.]

Sure, if you can consistently reproduce it i'll fix that one

[jelmer kuperus, modificado 13 Anos atrás.]

Hey James, just checking up on you to see if you have already logged the bug for me to look at