Vue combinée Vue Plate Arborescence
Sujets [ Précédent | Suivant ]
toggle
Corné Aussems
CSS Capitalization of Titles in Classic and Control Panel theme
22 septembre 2013 13:44
Réponse

Corné Aussems

Rang: Liferay Legend

Publications: 1311

Date d'inscription: 3 octobre 2006

Publications Récentes

Hi All
If you also dislike CSS Capitalization of Titles in Classic and Control Panel theme?!
Please vote this one up https://issues.liferay.com/browse/LPS-40467

Brendan Johan Lee
RE: CSS Capitalization of Titles in Classic and Control Panel theme
23 septembre 2013 03:06
Réponse

Brendan Johan Lee

Rang: Junior Member

Publications: 33

Date d'inscription: 29 février 2012

Publications Récentes

You've got my vote. This is a problem for Norwegian as well.
Olaf Kock
RE: CSS Capitalization of Titles in Classic and Control Panel theme
23 septembre 2013 03:31
Réponse

Olaf Kock

LIFERAY STAFF

Rang: Liferay Legend

Publications: 3431

Date d'inscription: 23 septembre 2008

Publications Récentes

You've got my vote - and a comment - in there as well. Full ACK that this is a no-go. If we had some way to determine the language through CSS (I couldn't find it) this could be done for distinct languages, but even that would be suboptimal. Rather have the translation entries be correct - as they shall display. If there are multiple uses for them, we'd need multiple keys for different uses.
Milan Jaroš
RE: CSS Capitalization of Titles in Classic and Control Panel theme
23 septembre 2013 12:58
Réponse

Milan Jaroš

Rang: Expert

Publications: 269

Date d'inscription: 18 août 2008

Publications Récentes

I'm with you. ;) In Czech this also doesn't feel good.
Off-topic: Olaf, there is an elegant way... emoticon Put css class like "en_us" to html tag <body> or even <html> and then you can do magic! emoticon
Olaf Kock
RE: CSS Capitalization of Titles in Classic and Control Panel theme
23 septembre 2013 13:18
Réponse

Olaf Kock

LIFERAY STAFF

Rang: Liferay Legend

Publications: 3431

Date d'inscription: 23 septembre 2008

Publications Récentes

Milan Jaroš:
Off-topic: Olaf, there is an elegant way... emoticon Put css class like "en_us" to html tag <body> or even <html> and then you can do magic! emoticon


Yes, but I don't consider language-dependent CSS elegant (ltr or rtl issues might be different, but still not language-dependent, only directional). Plus, I was checking if Liferay generates this class already (which it luckily doesn't). If I'd have to willingly code this into my theme, I could as well override the capitalizing CSS formatting to get rid of it.

So, yes, if you want this feature in CSS and language dependent, that's what you do. Just don't ask me for my blessing. Or I'll need an explain why it indeed is elegant emoticon

The good thing after all is that we're all agreeing. Please continue voting on the issue
Corné Aussems
RE: CSS Capitalization of Titles in Classic and Control Panel theme
23 septembre 2013 14:35
Réponse

Corné Aussems

Rang: Liferay Legend

Publications: 1311

Date d'inscription: 3 octobre 2006

Publications Récentes

It allready exist guys ;) languageId (seems not used in any filter though)
languageId=en_US
1
2<link href="/html/css/main.css?browserId=ie&amp;themeId=Componencetheme_WAR_Componencethemetheme&amp;minifierType=css&amp;languageId=en_US&amp;b=6120&amp;t=1341556890000" rel="stylesheet" type="text/css" />


And well if you dislike language dependent CSS, maybe you dislike hard rendered browserid too ;)
Taken from 6.2 M6
languageId=de_DE
browserId=other/firefox/ie
1
2<script src="http://localhost:8080/html/portlet/layouts_admin/js/main.js?browserId=other&amp;minifierType=js&amp;languageId=de_DE&amp;b=6200&amp;t=1379852642592" type="text/javascript"></script>


Remove those before anyone ever thinks of using it emoticon

Ever thought on how many Varnish caches you have to have for just one single page if you support all languages. (3 x many)
Olaf Kock
RE: CSS Capitalization of Titles in Classic and Control Panel theme
23 septembre 2013 14:40
Réponse

Olaf Kock

LIFERAY STAFF

Rang: Liferay Legend

Publications: 3431

Date d'inscription: 23 septembre 2008

Publications Récentes

Ouch - you're right.

I actually like <html class="... firefox ...">, but it's probably overkill to have it in the javascript URL, polluting all the caches. Not sure if it's used serverside though - are there different minifiers based on browsers? I'm not aware of any other server-side processing of javascript than the minifier.

Based on this, if you let us know the issue, I will vote for that as well. But we're getting away from translation issues here emoticon
Corné Aussems
RE: CSS Capitalization of Titles in Classic and Control Panel theme
24 septembre 2013 04:56
Réponse

Corné Aussems

Rang: Liferay Legend

Publications: 1311

Date d'inscription: 3 octobre 2006

Publications Récentes

Olaf Kock:
Ouch - you're right.

I actually like <html class="... firefox ...">, but it's probably overkill to have it in the javascript URL, polluting all the caches. Not sure if it's used serverside though - are there different minifiers based on browsers? I'm not aware of any other server-side processing of javascript than the minifier.

Based on this, if you let us know the issue, I will vote for that as well. But we're getting away from translation issues here emoticon


For your information
https://issues.liferay.com/browse/LPS-40526