I think there could be two problems in the following method:
public List<battlecardentry> getBattlecards() {
battlecards = (List<battlecardentry>) ApplicationAttribute
.getApplicationAttribute(CURRENT_BATTLECARDS_KEY);
// we only want to sortColumnName if the column or ordering has changed.
if (!oldSort.equals(sortColumnName) || oldAscending != ascending) {
sort();
oldSort = sortColumnName;
oldAscending = ascending;
}
SessionRenderer.render(groupName);
return battlecards;
}
</battlecardentry></battlecardentry>
1) Performance: Since managed-bean getter methods can be called many many times during the execution of the JSF lifecycle, the recommended practice is to always use lazy-initialization. For example:
public List<battlecardentry> getBattlecards() {
if (battlecards == null) {
battlecards = (List<battlecardentry>) ApplicationAttribute
.getApplicationAttribute(CURRENT_BATTLECARDS_KEY);
// we only want to sortColumnName if the column or ordering has changed.
if (!oldSort.equals(sortColumnName) || oldAscending != ascending) {
sort();
oldSort = sortColumnName;
oldAscending = ascending;
}
SessionRenderer.render(groupName);
}
return battlecards;
}
</battlecardentry></battlecardentry>
I would also recommend that you put in a System.err.println at the top of the method to see how often it gets called. I bet it's called a lot.
2) The call to SessionRenderer.render(groupName) should not be in a getter-method like this. Instead, it should be called when a button is clicked by the user, or when an asynchronous event happens on the server. Also because of problem#1, the call to SessionRenderer.render(groupName) is probably happening a bunch of times.
