Combination View Flat View Tree View
Threads [ Previous | Next ]
toggle
David H Nebinger
Impersonating New User should not bring up Terms Of Use...
June 5, 2012 9:43 AM
Answer

David H Nebinger

Community Moderator

Rank: Liferay Legend

Posts: 11046

Join Date: September 1, 2006

Recent Posts

I have a fix for http://issues.liferay.com/browse/LPS-3800 for Liferay 6.1. Since no work has been done to resolve it, I'm posting here to see if there is interest in committing my fix for 6.1.

Basically, in com.liferay.portal.struts.PortalRequestProcessor.processPath() the theme display must be checked to see if the user is being impersonated, and does not redirect to the terms of use, current password check, valid email address check, or password reminders pages.

If there is interest, I'll get my patch together and submit it...
Sampsa Sohlman
RE: Impersonating New User should not bring up Terms Of Use...
June 5, 2012 11:07 AM
Answer

Sampsa Sohlman

LIFERAY STAFF

Rank: Regular Member

Posts: 225

Join Date: September 27, 2007

Recent Posts

I'm usually disabling that feature, but it should not be there, if someone is impersonating user.

I vote for it.

- Sampsa
David H Nebinger
RE: Impersonating New User should not bring up Terms Of Use...
June 5, 2012 12:33 PM
Answer

David H Nebinger

Community Moderator

Rank: Liferay Legend

Posts: 11046

Join Date: September 1, 2006

Recent Posts

Snap! Brian Chan beat me to it in February... emoticon

It's in the trunk now, so I'm guessing it will be part of GA2...
Hitoshi Ozawa
RE: Impersonating New User should not bring up Terms Of Use...
June 30, 2012 9:32 AM
Answer

Hitoshi Ozawa

Rank: Liferay Legend

Posts: 7949

Join Date: March 23, 2010

Recent Posts

I just check the LPS in the first post and it seems to have been fixed by Douglas and should have been fixed in 6.0.0 preview?
If it's not working in 6.1.0 CE, it's probably wasn't fixed properly. :-)
David H Nebinger
RE: Impersonating New User should not bring up Terms Of Use...
June 30, 2012 9:47 AM
Answer

David H Nebinger

Community Moderator

Rank: Liferay Legend

Posts: 11046

Join Date: September 1, 2006

Recent Posts

Well, it's definitely broken in 6.0 EE SP2. I was going to submit a fix but once I started checking through the Git commits, I found that Brian had actually done it in February...
Hitoshi Ozawa
RE: Impersonating New User should not bring up Terms Of Use...
June 30, 2012 9:55 AM
Answer

Hitoshi Ozawa

Rank: Liferay Legend

Posts: 7949

Join Date: March 23, 2010

Recent Posts

once I started checking through the Git commits, I found that Brian had actually done it in February...


Do you know to which issue Brian did a fix? Wonder what Douglas did. It may have been regressed in 6.0?

I'm beginning to think liferay's jira isn't working very well. This may be the reason why liferay's quality isn't improving too much. :-)
David H Nebinger
RE: Impersonating New User should not bring up Terms Of Use...
June 30, 2012 9:01 PM
Answer

David H Nebinger

Community Moderator

Rank: Liferay Legend

Posts: 11046

Join Date: September 1, 2006

Recent Posts

Not off the top of my head, although it should be easy to find. Using the eGit plugin for Eclipse and looking at the history for the file is how I determined it was fixed in February and Brian was the committer, but I don't remember the comment that was associated w/ the change...
Hitoshi Ozawa
RE: Impersonating New User should not bring up Terms Of Use...
June 30, 2012 9:24 PM
Answer

Hitoshi Ozawa

Rank: Liferay Legend

Posts: 7949

Join Date: March 23, 2010

Recent Posts

Sorry but can't find any entries in liferay.portal.struts.PortalRequestProcessor.processPath() in Februrary authored by Brian Chan.

https://github.com/liferay/liferay-portal/commits/master/portal-impl/src/com/liferay/portal/struts/PortletRequestProcessor.java

hhuijser5 seems to have made some code formatting modifications
Mika Koivisto
RE: Impersonating New User should not bring up Terms Of Use...
July 2, 2012 3:19 PM
Answer

Mika Koivisto

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1512

Join Date: August 7, 2006

Recent Posts

It was fixed in LPS-8498.
Hitoshi Ozawa
RE: Impersonating New User should not bring up Terms Of Use...
July 2, 2012 3:59 PM
Answer

Hitoshi Ozawa

Rank: Liferay Legend

Posts: 7949

Join Date: March 23, 2010

Recent Posts

Thanks Mika. Seems you've made the modification and Brian Chan did the review as he does for all modifications. :-)
Mika Koivisto
RE: Impersonating New User should not bring up Terms Of Use...
July 9, 2012 1:55 PM
Answer

Mika Koivisto

LIFERAY STAFF

Rank: Liferay Legend

Posts: 1512

Join Date: August 7, 2006

Recent Posts

Yeah. I'm used to be rewritten at times :-)